This is just a minor annoyance, most folk seem to have
one or more of ACPI, APIC, and PCI.
Please merge.
- Dave
This changes the usbcore message about HCD IRQ problems so it makes
sense on systems without ACPI or an APIC. It also updates the comments;
the issue doesn't appiear only with PCI, and with the recent enumeration
changes it doesn't happen just with set_address either.
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
--- 1.109/drivers/usb/core/hcd.c Mon Nov 15 14:28:14 2004
+++ edited/drivers/usb/core/hcd.c Sun Nov 28 03:12:58 2004
@@ -1283,13 +1283,14 @@
goto done;
}
- /* PCI IRQ setup can easily be broken so that USB controllers
+ /* IRQ setup can easily be broken so that USB controllers
* never get completion IRQs ... maybe even the ones we need to
- * finish unlinking the initial failed usb_set_address().
+ * finish unlinking the initial failed usb_set_address()
+ * or device descriptor fetch.
*/
if (!hcd->saw_irq && hcd->self.root_hub != urb->dev) {
dev_warn (hcd->self.controller, "Unlink after no-IRQ? "
- "Different ACPI or APIC settings may help."
+ "Controller is probably using the wrong IRQ."
"\n");
hcd->saw_irq = 1;
}
