Hi Philipp,

You have done an impressive work on documenting all this.
Thanks a lot. I'm sure this will simplify the work of
others.


> (4) As Expected: define platform specific HCHWCFG_INIT, HCDMACFG_INIT,
> CHIP_TYPE, ... macros (HCCHIPID_MAGIC needs to be defined specific to  1160
> or 1362 - inlcuded in Olav's patch)

Perhaps it would be better to remove the xxx_INIT macros
from the driver and rather expand the struct ohci_chip_info
to import these values together with other platform-specific
stuff.

> Applying Big Endian Changes
> ---------------------------
>
> (3) The following 10-bit PTD access macros need to be changed, as it indexes
> 16-bit fields inside the PTD structure.
>
> - PTD_GET_COUNT
> - PTD_GET_MPS
> - PTD_GET_LEN
>
> Note: only the extracts seem to need the byte swapping, as they do the funky
> pointer conversion.

Just a question without too deep thinking - should the
macros in bitfield.h rather be changed instead of the
PTD_GET_xxx macros above? Are the bitfield.h macros
currently BE-compatible?

Olav



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to