Hi Greg, thanks for the feedback; I'll try to incorporate it soon.
I do have a couple quick questions:
- Should I just use diff -bB to avoid the whitespace changes I accidentally introduced?
+static ssize_t show_event_char(struct device *dev, char *buf);
+static ssize_t store_event_char(struct device *dev, const char *buf, size_t count);
+static DEVICE_ATTR(event_char, S_IWUGO | S_IRUGO, show_event_char, store_event_char);
If you put these before where they are called, you don't need a forward
declaration at all, right?
- Are forward declarations to be avoided when possible? (as a general rule)
- Should I, as a rule, always submit patches against the latest pre/rc?
And on a semi-unrelated subject, once I have all these snazzy attributes, I'd like to be able to access them given the udev name. Udevinfo can provide me with *a* sysfs path, which so far always seems to be in the /class/tty hierarchy. I can then map this path to a path in /device via libsysfs.
Will udevinfo *always* provide me with a /class path, or do I need to be able to deal with whatever sysfs path udev gives me (ick!)?
Is there a better way to get to my attributes from a /dev/ttyUSB0 path (which is actually renamed via udev to /dev/orc)?
Thanks,
-Ed
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
