On Thursday 09 December 2004 12:46 pm, Greg KH wrote:
> When building with:
> $ make C=1 M=drivers/usb/host/ CHECK='sparse -Wbitwise'     
> 
> I get the following error:
>   CHECK   drivers/usb/host/ehci-hcd.c
> drivers/usb/host/ehci-dbg.c:397:28: warning: incompatible types for operation 
> (==)
> drivers/usb/host/ehci-dbg.c:397:28:    left side has type restricted unsigned 
> int hw_qtd_next
> drivers/usb/host/ehci-dbg.c:397:28:    right side has type unsigned int 
> qtd_dma
> 
> That looks to be a real bug.  Any thoughts on how to fix it?

Make the left side call le32_to_cpu(qh->hw_qtd_next), so that when
DMA addresses are 64 bits it still behaves.  Real bug, but not many
folk should be using that file ... :)

Was that all that sparse said?  When I've tried it, most options
seem to emit so many false positives as to make the output be not
very useful.

- Dave



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to