Hi Roman,

> +#define DRIVER_DESC  "Generic USB ATM/DSL core I/O driver version " 
> DRIVER_VERSION

Maybe "Generic USB ATM/DSL I/O, version "
(Core and generic are almost repeating each other; as are I/O and driver).

>  static unsigned int num_rcv_urbs = UDSL_DEFAULT_RCV_URBS;
>  static unsigned int num_snd_urbs = UDSL_DEFAULT_SND_URBS;
> @@ -386,10 +386,6 @@
>       if (!(ctrl->num_cells -= ne) || !(howmany -= ne))
>               goto out;
>  
> -     if (instance->snd_padding) {
> -             memset(target, 0, instance->snd_padding);
> -             target += instance->snd_padding;
> -     }
>       udsl_fill_cell_header(target, ctrl->atm_data.vcc);
>       target += ATM_CELL_HEADER;
>       memcpy(target, skb->data, skb->len);
> @@ -404,6 +400,10 @@
>                       goto out;
>               }
>  
> +             if (instance->snd_padding) {
> +                     memset(target, 0, instance->snd_padding);
> +                     target += instance->snd_padding;
> +             }
>               udsl_fill_cell_header(target, ctrl->atm_data.vcc);
>               target += ATM_CELL_HEADER;
>               memset(target, 0, ATM_CELL_PAYLOAD - ATM_AAL5_TRAILER);

This is change is correct.  Thanks for fixing it!

All the best,

Duncan.


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to