On Thu, Jan 13, 2005 at 10:03:59AM +0100, Florian Echtler wrote: > > Can you use dev_info() here? It's more descriptive. Also, if > > CONFIG_USB_DYNAMIC_MINORS is set, this number will print out negative, > > which I don't think you want. > Okay.. BTW, can you give it a minor number? And should I include it > into the code, or will you (it's #defined at the beginning of idmouse.c).
I'll do it. How many minor numbers do you want? Is 1 ok? Will you ever be backporting this driver to 2.4 (it matters in the number I give you.) I've applied your driver as is to the tree, and then fixed up some sparse warnings that were found with it (__user and le16_to_cpu() needed to be added in places.) thanks, greg k-h ------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
