On Thu, Jan 20, 2005 at 12:15:23AM +0100, Thomas Winischhofer wrote:
> Greg KH wrote:
> | Ah, one more common style fixup that you should fixup:
> |
> |
> |>+static void sisusb_kill_all_busy(struct sisusb_usb_data *sisusb)
> |>+{
> |>+ int i;
> |>+
> |>+ if (sisusb_all_free(sisusb)) {
> |>+ return;
> |>+ }
> |
> |
> | For if and for loops that only have 1 statement, don't add the { } to
> | them, it's not needed.
>
> OK, I know it's not needed. But leaving them out is more error prone and
> makes the code less readable due to code entities not appearing in the
> same way clearly. Don't you think you're a bit too picky now? ;)
Obviously you haven't seen code reviews on linux-kernel before :)
Seriously, people will complain. If you don't believe me, post it
there...
thanks,
greg k-h
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
