On Wed, Jan 26, 2005 at 02:49:02PM -0800, Greg KH wrote: > On Wed, Jan 26, 2005 at 02:25:33PM -0800, Pete Zaitcev wrote: > > On Wed, 26 Jan 2005 14:11:11 -0800, "Micon, David" <[EMAIL PROTECTED]> > > wrote: > > > > > You are right. Here is a new patch that will make sure that the state is > > > set to TASK_INTERRUPTIBLE whenever the > > > key condition is tested. > > > > > > --- old/drivers/usb/input/hiddev.c 2004-03-17 05:02:08.000000000 > > > -0800 > > > +++ new/drivers/usb/input/hiddev.c 2005-01-26 11:34:06.399553881 > > > -0800 > > > @@ -338,6 +338,7 @@ > > > } > > > > > > schedule(); > > > + set_current_state(TASK_INTERRUPTIBLE); > > I thought that after schedule() got called, the state was > TASK_INTERRUPTIBLE. Or am I just imagining things?
I didn't get the original patch, but wouldn't it be better to just rework this using wait_interruptible()? -- Vojtech Pavlik SuSE Labs, SuSE CR ------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
