On Mon, Jan 31, 2005 at 11:40:22AM -0800, Nishanth Aravamudan wrote:
> On Mon, Jan 31, 2005 at 11:33:28AM -0800, Greg KH wrote:
> > On Mon, Jan 31, 2005 at 11:27:03AM -0800, Nishanth Aravamudan wrote:
> > > On Mon, Jan 31, 2005 at 10:51:59AM -0800, Greg KH wrote:
> > > > On Fri, Jan 21, 2005 at 01:36:35PM -0800, Nishanth Aravamudan wrote:
> > > > > Hi,
> > > > >
> > > > > Please consider applying.
> > > > >
> > > > > Description: Use wait_event_timeout() instead of custom wait-queue
> > > > > code. Remove
> > > > > now unused variables. I changed the code to only add to the
> > > > > wait-queue if
> > > > > necessary, but I'm not sure if this is correct.
> > > >
> > > > Please at least compile your patches to make sure they build. This one
> > > > does not :(
> > >
> > > I'm not seeing a build error here; what errors are coming up for you?
> >
> > Don't remember anymore, as I reverted the patch already...
> >
> > I think it was a {} matching issue like your other patches.
>
> You are right. I had actually fixed this, but didn't mail the updated diff.
> Sorry about that, Greg.
>
> Please consider the following which builds cleanly.
>
> Description: Use wait_event_timeout() instead of custom wait-queue code.
> Remove
> now unused variables. I changed the code to only add to the wait-queue if
> necessary, but I'm not sure if this is correct.
>
> Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]>
Applied, thanks.
greg k-h
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
