On Wed, 2 Feb 2005, Nick Sillik wrote: > I have made an official release of the Maxtor OneTouch driver for the > linux kernel.
> I would really appreciate any tips on how to improve this, and hopefully > get this included in the kernel. The use of macros double-checking for whether the driver is a module or is compiled into the kernel is very awkward. What happens when monetouch is built into the kernel but usb-storage is a module? Why isn't monetouch simply defined as an additional subhandler to be compiled into usb-storage, rather than as a completely separate module? You have a race condition when unsetting the onetouch_connect_inputp and onetouch_release_inputp pointers. The routines might be in use at the time. Your header file includes "linux/input.h" rather than <linux/input.h>. The comment is pointless. And what is nullfunc? The code changes to storage_probe() shouldn't contain #if's. Alan Stern ------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
