On Wed, 2 Feb 2005, David Brownell wrote: > > > - Probably usb_add_hcd() should drop the IRQ handler parameter; > > > everything should use the standard filter. (All existing cases > > > where something else is used are wrong.) > > > > Okay. This means removing the other handlers too, right? > > There should be handlers in the hc_driver struct; delete the layer > that just calls the standard filter, it's pointless! > > I had one in sl811 as an oversight (didn't notice till Olav cloned it > in his isp116x-hcd and had a problem!), the lh7a404 should have been > removed before merging, and the issue being addressed in sa1111 should > be addressed elsewhere (always return IRQ_HANDLED).
The handler in sl811-hcd wants the irq number as an argument (which is standard for irq handlers), but the other drivers follow the prototype in hcd.h which omits that argument. What should I do -- add an unused argument to all the other handlers? > - For the sl811, please don't switch to the driver model diagnostics. > As with pretty much every driver using the platform bus, they're just > annoying: there's no point in having every driver message preceded > by _two_ copies of the driver name. (Especially for the sl811: if > there were a need for more than one root hub port, the designer would > have chosen a different controller, not used two of those!!) Then should I also change the diagnostics in lh7a404, pxa27x, and sa1111 back to the pr_debug style? (The sa1111 driver used the dbg macro rather than pr_debug...) Alan Stern ------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
