> I've dropped this now.  It caused the usb-bk tree to be dropped from the
> -mm releases due to it causing build errors if CONFIG_DEBUG_FS not being
> enabled.  Andrew sent me a horrible hack to try to fix it up, but I'm
> going to trust you to fix it up properly :)

Here's a proper fix (well, it's a little hackish, but better than Andrew's 
I hope).  No more build problems if CONFIG_DEBUG_FS isn't set.

Alan Stern

P.S.: Where in the kernel build system is the DEBUG_FS option defined?  
It's not in any Kconfig file.



Signed-off-by: Alan Stern <[EMAIL PROTECTED]>

===== drivers/usb/host/uhci-debug.c 1.31 vs edited =====
--- 1.31/drivers/usb/host/uhci-debug.c  2005-01-25 12:46:23 -05:00
+++ edited/drivers/usb/host/uhci-debug.c        2005-02-04 17:57:42 -05:00
@@ -17,6 +17,8 @@
 
 #include "uhci-hcd.h"
 
+static struct dentry *uhci_debugfs_root = NULL;
+
 /* Handle REALLY large printk's so we don't overflow buffers */
 static inline void lprintk(char *buf)
 {
@@ -497,8 +499,6 @@
 
 #define MAX_OUTPUT     (64 * 1024)
 
-static struct dentry *uhci_debugfs_root = NULL;
-
 struct uhci_debug {
        int size;
        char *data;
@@ -579,4 +579,9 @@
        .read =         uhci_debug_read,
        .release =      uhci_debug_release,
 };
+
+#else  /* CONFIG_DEBUG_FS */
+
+#define uhci_debug_operations (* (struct file_operations *) NULL)
+
 #endif



-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to