On Tuesday 08 February 2005 10:05 pm, Nishanth Aravamudan wrote: > - USB_REQ_CLEAR_FEATURE, USB_RT_HUB, feature, 0, NULL, 0, HZ); > + USB_REQ_CLEAR_FEATURE, USB_RT_HUB, feature, 0, NULL, 0, 1000);
You know, changing from symbols to magic numbers is not a win. People know what something involving HZ is intended to mean, but 1000 is just another magic number ... Rather than 1000 how about something like "1 * MS_PER_SEC" or something similar? I especially don't like to see magic numbers added to usbcore, but the same issue applies to a lot of drivers too. - Dave ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
