On Wed, Feb 09, 2005 at 11:49:42AM -0500, Alan Stern wrote: > On Wed, 2 Feb 2005, Matthew Dharm wrote: > > > On Wed, Feb 02, 2005 at 11:57:57AM -0500, Alan Stern wrote: > > > Below is a patch for 2.6.11-rc2 that makes write-protect detection into a > > > module parameter. Matt Dharm has considered doing this in the past; I > > > don't remember if he came to a final decision. > > > > Is there a place where we can keep all that useful descriptive text? I > > really don't want to throw it away, just to be bombarded by "what's this > > parameter for" questions... > > Considering that only a small number of devices are unable to handle > write-protect detection (I've seen reports for no more than two), maybe we > should just make it into another unusual_devs flag? That way there's > nothing to configure either during a build or at runtime.
I think this is valid only if many people are setting
CONFIG_USB_STORAGE_RW_DETECT. Do you think that's a valid assumption? I'm
not sure...
> Originally we made it a config option because it caused trouble so often.
> But now that we always request a 192-byte transfer, it almost never fails.
> Changing it to a device flag would be the simplest approach.
If most people are already setting the option, then this is probably a good
idea.
Matt
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
You suck Stef.
-- Greg
User Friendly, 11/29/97
pgpANhlAYslI7.pgp
Description: PGP signature
