On Monday 14 February 2005 4:59 pm, Christopher Hoover wrote:
>
> > The other path introduced by my patch where IRQ_NONE can be returned
> > gets used only at times when the controller is not running
> > and hence is
> > incapable of generating interrupts. So it shouldn't be a problem.
> >
> > Would this be satisfactory? Or do you prefer to change the
> > core interrupt
> > routines?
>
> The patch looks OK to me.
It'd be cleaner to have the #define be for the value that's returned
in that branch rather than have two #ifdefs, and I'd rather see it
resolved that way. But other than that, I agree.
- Dave
#if defined(CONFIG_SA1111) /* ... or other edge-triggered systems */
#define IRQ_NOTMINE IRQ_HANDLED
#else
#define RIQ_NOTMINE IRQ_NONE
#endif
...
return IRQ_NOTMINE;
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
