David Hollis wrote:
The only issue that I see is that the usbnet_open() function (which
calls the ax8817x_reset) is only called when the interface is brought
from DOWN to UP state. If I initially connect to a 100FD switch, then
unplug and plug into a 10HD hub, things may get squirrely. If I bring
the device down and back up, things will reset and I'll be fine. Would
it possibly be better to handle this within the interrupt handler that
sees when link changes? That is an in_interrupt() call so you'd have to
use the async read/write_cmd calls and implement an FSM to handle it.
But there weren't too many calls so it shouldn't be a major issue.
Good point. I tried setting AX_MEDIUM_FULL_DUPLEX when in half duplex mode, and the interface still works, but performance is worse than when it's turned off. That's why I check the capabilities of the link partner to decide whether to set that bit.
I'll take a look at dealing with the issue in an interrupt handler.
--Jamie
------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
