On Thu, Feb 03, 2005 at 06:20:38PM +0200, Petko Manolov wrote: > Hi Greg, > > When the bonding driver attempts to read the link status via > xxx_get_settings() the enslaved usb-eth driver crash the kernel. Which > shouldn't be much of surprise - since pegasus|rtl8150_get_settins() is > been called from a timer. The original work was done by Mike Nix - > thanks. > > Fixed that using in_atomic() check. I am not sure this is the best/proper > thing to do, although it seems to work. > > Haven't checked the other usb-ethernet drivers, but i suspect they are as > vulnerable as pegasus and rtl8150 are. It's probably a good idea to warn > their respective maintainers.
Hm, I get the following build error with this patch: drivers/usb/net/pegasus.c: In function `check_carrier': drivers/usb/net/pegasus.c:1167: error: structure has no member named `carrier_check' drivers/usb/net/pegasus.c: In function `pegasus_probe': drivers/usb/net/pegasus.c:1198: error: structure has no member named `carrier_check' drivers/usb/net/pegasus.c:1198: error: structure has no member named `carrier_check' drivers/usb/net/pegasus.c:1198: error: structure has no member named `carrier_check' drivers/usb/net/pegasus.c:1198: error: structure has no member named `carrier_check' drivers/usb/net/pegasus.c:1198: error: structure has no member named `carrier_check' drivers/usb/net/pegasus.c:1198: error: structure has no member named `carrier_check' drivers/usb/net/pegasus.c:1198: error: structure has no member named `carrier_check' drivers/usb/net/pegasus.c:1198: error: structure has no member named `carrier_check' drivers/usb/net/pegasus.c:1244: error: structure has no member named `carrier_check' drivers/usb/net/pegasus.c: In function `pegasus_disconnect': drivers/usb/net/pegasus.c:1271: error: structure has no member named `carrier_check' So I'm not going to apply it :) thanks, greg k-h ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
