On Fri, Feb 25, 2005 at 02:09:55PM +0000, Paulo Marques wrote: > Greg KH wrote: > >[...] > >+ if (cf->string) > >+ kfree(cf->string); > > [minor nitpick] > > This test isn't needed, is it? > > Unless you want to make sure that noone will use the string after > freeing in which case this should be:
Good point, I've cleaned this now up. thanks, greg k-h ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
