On Sat, Feb 26, 2005 at 05:32:34PM +0100, Olaf Hering wrote:
> On Thu, Feb 24, Greg KH wrote:
>
> > +++ b/drivers/usb/core/hub.c 2005-02-24 11:15:13 -08:00
> > @@ -1102,23 +1102,31 @@
> > }
> >
> > #ifdef DEBUG
> > -static void show_string(struct usb_device *udev, char *id, int index)
> > +static void show_string(struct usb_device *udev, char *id, char *string)
>
> > +#else
> > +static inline void show_string(struct usb_device *udev, char *id, int
> > index)
> > +{}
> > +#endif
>
> > + show_string(udev, "Product", udev->product);
> > + show_string(udev, "Manufacturer", udev->manufacturer);
> > + show_string(udev, "SerialNumber", udev->serial);
>
> The non-debug declaration is wrong.
Already fixed in my tree with the following patch. Kay pointed this out
yesterday.
thanks,
greg k-h
-----
Date: 25 Feb 2005 11:01:10 -08:00
From: [EMAIL PROTECTED]
Subject: USB: fix up compiler warnings when CONFIG_USB_DEBUG is not set.
As pointed out by Kay Sievers <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
--- a/drivers/usb/core/hub.c 2005-02-25 11:04:29 -08:00
+++ b/drivers/usb/core/hub.c 2005-02-25 11:04:29 -08:00
@@ -1110,7 +1110,7 @@
}
#else
-static inline void show_string(struct usb_device *udev, char *id, int index)
+static inline void show_string(struct usb_device *udev, char *id, char *string)
{}
#endif
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
