On Wed, Mar 02, 2005 at 06:24:07PM +0300, Alex Kanavin wrote:
[...]
> +/*
> + * Helper function to usbobex_find_interfaces 
> + */
> +struct usb_obex_intf* check_intf(struct usb_device* dev, int c, int i, int 
> a, struct usb_obex_intf* current)

This function should be static.

> +/*
> + * Helper function to usbobex_find_interfaces 
> + */
> +int find_obex_data_interface(unsigned char* buffer, int buflen, struct 
> usb_config_descriptor config, struct usb_obex_intf* intf)

This should be static too.

> +/*
> + * Helper function to usbobex_find_interfaces 
> + */
> +void find_eps(struct usb_obex_intf* intf, struct usb_interface_descriptor 
> data_intf, int* found_active, int* found_idle)

And this should be static too.

BTW, "-export-symbols $(top_srcdir)/src/obex.sym" in
openobex/src/Makefile.am does not really hide any symbols at least on
Linux/i386 - it strips them from the normal symbol table (which is used
for linking object files and debugging), but does not change the dynamic
symbol table in the shared library (you can check it with "nm --dynamic"
or "objdump -T").  Therefore global symbols which are not mentioned in
obex.sym can still conflict with the symbols used by the program linked
with the shared library (if a function with the same name is defined in
the program, the implementation from the program will be used instead of
the code in the shared library).

Attachment: pgpt1r0dJaWj9.pgp
Description: PGP signature

Reply via email to