On Friday 04 March 2005 5:32 am, Ian Campbell wrote: > > There seem to be a few strange things about the sl811 driver that I > don't understand, and the changelog says compile tested only so I'll > bring them up here, and CC you David, since your name is in the > signed-off-by.
Yes, and you might also look at this thread: http://marc.theaimsgroup.com/?t=110840797300003&r=1&w=2 I have one board with an sl811, running 2.6.9 ... I hope I can just swap in the whole 2.6.11 USB stack in to test things, since I have no desire to forward-port all the board support! > First thing: where is ep->hep, the pointer from struct sl811h_ep to > struct usb_host_endpoint, initialised? I can see where hep->hcpriv is > set to ep to give the link the other way. I added the initialisation of > ep->hep at the same point as hep->hcpriv, I get segfaults otherwise. That did indeed look like it needed to be done. > I also couldn't find where urb->hcpriv was set to NULL when the urb was > finished -- not doing this causes usb_submit_urb() to return -EINVAL > next time the URB is submitted. I do it in finish_request() which seems > to match up with ohci-q doing it in finish_urb(). I thought usbcore was doing that; I guess not. - Dave ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
