On Monday 07 March 2005 9:47 am, David Hollis wrote: > > It seems that I can re-factor the ax8817x code to make use of this > instead of manually creating/handling the INT URB to reduce the > duplicity eh?
I'd sure hope so! Ideally, without needing to tweak any of the infrastructure; but if it's needed, we'd work that out. > How about Jamie's use of the kevent to take care of the > link/speed negotiation bits? You mean, as found in his usbnet-ax8817x-medium-mode-take2.patch? I see that uses the bit 3 flag for a different purpose ... :) That'd be a different mechanism. I didn't see anything wrong with such a mechanism on first read, but I didn't have time to give it a serious review and notice more than the fact that it was specific to the ASIX support. > Would it still be legit to use that > (changing the kevent flag accordingly of course) for the various ways we > need to handle that with the three different ASIX devices? I think what I'd like to see is a generalized mechanism that just lets the minidrivers say "call my function in (work) task context". Probably with some mechanism to cache minidriver-specific parameters for the call. A generic KEVENT_MINIDRIVER might suffice, plus maybe another word or two of minidriver-specific state. As you know, my not-so-secret plan is to see the usbnet core mature enough that minidrivers (like CDC Ethernet and ASIX) can split out into separate files, like usb-serial ... and so that potentially that infrastructure can be reused by other usb networking drivers. Doing that certainly seems to require having a good reusable solution for operations that need task contexts ... control requests to poll link status, and so on. In fact, given this status polling stuff, that's about the last technical issue I know of other than not yet having the serial-style modularization. - Dave ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
