On Tuesday 08 March 2005 5:29 am, David Hollis wrote:
> This patch migrates the ax8817x code to use the interrupt status
> infrastructure from usbnet-0203c.patch. This removes considerable
> duplicate
> code.
Looks good to me, but:
> +struct ax88172_int_data {
> +�������u16 res1;
> +�������u8 link;
> +�������u16 res2;
> +�������u8 status;
> +�������u16 res3;
> +};
Shouldn't that end "} __attribute__ ((packed));"? Not that the code seems to
care about offsets beyond that for "link" just now, though... but in case some
later update wants to use those fields (with get_unaligned etc), it'd help.
- Dave
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id396&op=click
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
