On Tue, 8 Mar 2005, David Brownell wrote: > Those of you making heavy use of usbfs, please see if this hurts. > It should just filter out some bogus requests that were previously > passed through, and replace some cryptic indirect logic with code > that's more obviously correct. > > I've done basic sanity testing with it; gphoto2 still seems not > to know how to recover from certain PTP states, but it can talk > with a camera, as can 'lsusb'.
Your use of the new is_in variable looks a little strange. It gets assigned, used once, then ignored for deciding the direction of control transfers. Why not instead handle the control transfer case directly at the spot where is_in is defined (there's a perfect opportunity a few lines down) and then use it consistently? Also you could make things slightly simpler if is_in stored the direction mask rather than a boolean flag. Alan Stern ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
