Dmitry,
Hi,
On Tue, 08 Mar 2005 11:55:47 -0500, Nick Sillik <[EMAIL PROTECTED]> wrote:
+struct usb_onetouch_wrap { + struct list_head list; + struct usb_onetouch *onetouch; +};
I may be wrong but I thought USB connect routines could run simultaneously if devices are on different hubs. If so then this list should be protected.
This I will definitely look into. First to check if you are right, then next to correct the problem if you are.
+ /* Attempt to connect the onetouch urb to the device */ + /* Note: If the CONFIG_USB_STORAGE_ONETOUCH is not set */ + /* onetouch_connect_input(us) will always return 0 */ + switch (onetouch_connect_input(us)) { + case 0: + break; + default: + printk(KERN_WARNING USB_STORAGE + "Unable to allocate onetouch urb\n"); + } +
Does it really need to be a switch?
Right now, no, it does not need to be a switch. But at some point onetouch_connect_input() will return more values. I suppose i would be able to handle them internally, so you are probably right, I will fix this one right now.
Nick Sillik [EMAIL PROTECTED]
signature.asc
Description: OpenPGP digital signature
