On Saturday 12 March 2005 8:40 am, Alan Stern wrote: > David: > > Here are some some changes I want to make in the near future: > > As part of the ongoing campaign to flatten the hcd glue layer, > merge the hcd_register_root macro and the usb_register_root_hub > function into a single function. > > Change the USB_STATE_RUNNING etc. constants to HC_STATE_RUNNING > etc. Using HC_ instead of HCD_ seems more logical because > they describe the state of the controller, not of the driver. > > Any objections? Those sound fine.
> Also, somewhat farther down the road, it would be nice to straighten out > the include files in drivers/usb/core. Put all the usbcore-private stuff > into usbcore.h, and take out all the constants and other things of > interest to HC drivers from hub.c and put them in a new usb_ch11.h file. > Maybe even move it into include/linux. What do you think? The hub stuff might reasonably go into a usb_ch11.h file, for use by the hub and root hub drivers. Likewise the various other usbcore-to-hcd calls might reasonably fit into one file; that's messier than needed. I tend to dislike the idea of putting them into <linux/*.h> files, just on the grounds that those are usbcore internal APIs, and I can't see them being "fully cooked" for some time yet. But that's incidental. - Dave > Alan Stern > > ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
