Vojtech Pavlik wrote:
On Sun, Mar 13, 2005 at 02:16:51PM -0500, Adam Kropelin wrote:
HID items of width 32 (bits) or greater are incorrectly extracted
due to
a masking bug in hid-core.c:extract(). This patch fixes it up by
forcing
the mask to be 64 bits wide.


Signed-off-by: Adam Kropelin <[EMAIL PROTECTED]>

Thanks; applied. Did you actually test this with a real device that has more than 32 bit items?

No, I encountered the bug with a device that has items of exactly 32 bits. The mask in that case was 0, so the extracted value always appeared to be 0. I did a little experimenting in userspace and concluded any widths >= 32 bits would be affected.


--Adam



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to