Am Dienstag 22 MÃrz 2005 20:38 schrieb David Brownell: > On Tuesday 22 March 2005 2:05 am, Karsten Wiese wrote: > > > On Sunday 20 March 2005 4:06 am, Karsten Wiese wrote: > > > > Without Hunk 1 ehci sitd's "Buffer Pointer (Page 1)" initialisation is > > > > wrong, > > > > > > This still doesn't seem quite right. In fact "buf1" initialization in > > > sitd_sched_init() looks seriously borked. I don't see how resizing to > > > u32 could help ... the relevant field in the sITD is five bits, not 16! > > > > handling of those five lsbits "TRANSACTION POSITION" & "TRANSACTION COUNT" > > (you mean those?) > > isn't touched by the u16 to u32 change. > > Good point. It just changes how I as thinking of the usage of buf1; > better match for the current code, I guess. > > > > its bits [31:12] where u32 instead of u16 really helps. > > with u16, bits [31:16] of packet->buf1 don't exist physically, thusly > > compiler must think they are 0. > > so we only set dma address correctly with u32 in sitd_patch()'s line: > > sitd->hw_buf [1] = cpu_to_le32 (uf->buf1); > > > > > And sitd_patch() does the wrong stuff too. > > The thing that was really wrong was handlig of the buffer-crossing case. > It wasn't properly detected, and the 64bit-dma wasn't setup right either. > (Not that anything turns on 64bit DMA just now.) > > > > > So what I'll do is post a revised patch merging all your split ISO fixes, > > > with sitd_sched_init() and sitd_patch() updated to handle sitd->hw_buf[1] > > > better ... and not just growing this field to 32 bits. > > > > looking forward to check the right stuff out. > > Well, this looks right to me, but as you know I don't have a good way to > reproduce it. See if this version behaves for you.
It does. No crackles here:-) Karsten ------------------------------------------------------- This SF.net email is sponsored by Microsoft Mobile & Embedded DevCon 2005 Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows Embedded(r) & Windows Mobile(tm) platforms, applications & content. Register by 3/29 & save $300 http://ads.osdn.com/?ad_idh83&alloc_id149&op=click _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
