On Wednesday 23 March 2005 12:07, Sergey Vlasov wrote:
> > +static void onetouch_close(struct input_dev *dev)
> > +{
> > +ÂÂÂÂÂstruct usb_onetouch *onetouch = dev->private;
> > +
> > +ÂÂÂÂÂif (!--onetouch->open_count)
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂusb_kill_urb(onetouch->irq);
> 
> However, I don't see lock_kernel() (or any other locking) in the close
> path. ÂE.g., when closing a /dev/input/event*:
> 

This is fixed in input core (did not make to Linus yet) - open and close
are serialized and called only for the first/last user. So very soon that
open_count variable will not be needed at all.

-- 
Dmitry


-------------------------------------------------------
This SF.net email is sponsored by Microsoft Mobile & Embedded DevCon 2005
Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows
Embedded(r) & Windows Mobile(tm) platforms, applications & content.  Register
by 3/29 & save $300 http://ads.osdn.com/?ad_idh83&alloc_id149&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to