Greg: Since I know you're super-busy figuring out this non-bk world, I'll save you some time and tell you I sign-off the patch below.
Sven Anderson wrote: > Hi Phil, > > Phil Dibowitz wrote: > >> 1. You're adding product IDs 1202, 1203, 1204, and 1205. 1203 was >> already there, but you remove it, OK, but 1205 is already there, so >> you'll need to fix that. > > > I was not removing 1203, it's just the extension of the bcd range. Yes, that's what I was trying to say... > I just copied from other entries. There're a lot 0xffffs in > unusual_dev.h, so I assumed it is correct. I changed it to 0x9999. Yes. It will work, but I figure new patches should be correct. =) >> 3. It's rather obnoxious to take the original submitter's credit away. > > I didn't remove it, I changed it to "based on...". Because I changed > something (the range) in his entry, I thought it is the best to take the > responsibility but keep the origin. Anyway, in the new patch I did it in > a different way. You said "based on?" I must have missed that. That would have been fine, my apologies. The below is also fine. >> 4. Your /proc/bus/usb/devices shows 1204, but I see no evidence 1202 is >> really an iPod. > > > I don't have an old iPod mini, but you find a lot of evidence here: > > http://www.google.com/search?q=0x1202+ipod > > Especially this one: > > http://www.qbik.ch/usb/devices/showdescr.php?id=2737 I'm happy with that. > No, the patch was ok, but I agree it looks strange. It's not very > readable, because I cannot tell diff to work blockwise instead of > linewise. Because of the similarity of the entries, diff splits and > merges them. Anyway, the new patch "looks" better. ;-) This looks good. Thanks for the patch. Greg, can you please apply? > Signed-off-by: Sven Anderson <[EMAIL PROTECTED]> Signed-off-by: Phil Dibowitz <[EMAIL PROTECTED]> -- Phil Dibowitz [EMAIL PROTECTED] Freeware and Technical Pages Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "They that can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety." - Benjamin Franklin, 1759
signature.asc
Description: OpenPGP digital signature
