On Mon, Apr 18, 2005 at 08:41:58AM +0400, Roman Kagan wrote: > On Sun, Apr 17, 2005 at 04:19:15PM -0700, Greg KH wrote: > > On Sat, Apr 09, 2005 at 09:55:21AM +0400, Roman Kagan wrote: > > > On Fri, Apr 08, 2005 at 02:49:13PM -0700, Greg KH wrote: > > > > On Thu, Mar 31, 2005 at 07:40:46PM +0400, Roman Kagan wrote: > > > > > Any chance to get my other patch re. modifying the module alias > > > > > patterns > > > > > in usb modules to correctly handle bcdDevice ranges included? I'm a > > > > > bit > > > > > worried about this one included without that one, because it's sort of > > > > > encouraging the interface which used to be broken. > > > > > > > > In thinking about it a lot, I don't want to accept that change. I don't > > > > think it is wise to break userspace tools in such a bad way. Especially > > > > as I don't see a need for this (no one ever relied on matching based on > > > > the bcdDevice range before, and if they did, the kernel handled it > > > > properly internally anyway.) > > > > > > I disagree with both your arguments :) > > > > > > 1) I'm unaware of any existing userspace tool which would be broken by > > > that, exactly because it was practically impossible to create one; > > > > Um, all of the existing hotplug scripts would break, if you modified the > > file by removing a field there, right? That wouldn't be good at all. > > Which existing hotplug scripts are you talking about? > hotplug-2004_09_23 (the latest on ftp.kernel.org) doesn't ever look at > the aliases, it parses modules.*map instead.
And your patch modified the map file which is created, right? That's the part that I object to. > > > 2) now that MODALIAS is generated by the kernel, it will be the kernel > > > which will be broken: for a number of drivers _no_ MODALIAS will > > > match the MODULE_ALIAS_TABLE, and the userspace will have little to > > > do about it. > > > > No, see how I modified the patch. It's in the -mm tree. > > OK, looking forward to it reaching some public place where I can see it > (it's not in 2.6.12-rc2-mm3, is it?). Yes it is. Or it should be. Hm, I think it made it into 2.6.12-rc2 already, which is what you responded to in this thread :) thanks, greg k-h ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
