On Mon, 25 Apr 2005, Greg KH wrote: > On Mon, Apr 25, 2005 at 11:29:50AM -0400, Alan Stern wrote: > > Greg: > > > > This patch adds a reboot notifier to uhci-hcd so that it can quiesce the > > controller hardware during a reboot. This is mainly to benefit programs > > like kexec, which expect the hardware to be idle, not doing DMA or > > generating IRQs. > > What's wrong with the device_shutdown call instead? Otherwise _all_ > drivers are going to start adding a reboot notifier, which will just get > very ugly...
In principle there's nothing wrong with it, as far as I know. Other people might be able to raise more concrete objections. The real difficulty is that the PCI core doesn't support device_shutdown! I suppose the patch could be changed to set the appropriate field in pci_dev.driver directly, bypassing the PCI core. On the other hand, perhaps you'd prefer to add device_shutdown support to PCI. Alan Stern ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
