Hello Greg , Thanks for the help on the missed coding conventions . I will definitely incorporate those .
I may not be able to send the entire driver code but I can send some important functions you need to help me debug the issues. Let me know if this is fine . Meanwhile , would it be possible to help regarding the issues with minicom and read flow in the driver. Any pointers ? Has these been observed by you when testing other USB-Serial drivers . Thanks , Monali. > -----Original Message----- > From: Greg KH [mailto:[EMAIL PROTECTED] > Sent: Friday, April 29, 2005 9:15 PM > To: Monali Vishnu Katkar (WT01 - EMBEDDED & PRODUCT > ENGINEERING SOLUTIONS) > Cc: linux-usb-devel@lists.sourceforge.net; [EMAIL PROTECTED] > Subject: Re: Needed help on the usb-serial driver- debugging > read/write issues > > > On Fri, Apr 29, 2005 at 05:48:16PM +0530, > [EMAIL PROTECTED] wrote: > > > > > > Hello Greg , > > My code does tries to follow coding conventions. I have > referred the > > CodingStyle doc.The file I sent was a txt file enough to view some > > important portions of the code. > > > > I am not sure what you meant by not following coding conventions. > > Let's start with the most basic rules that you did not follow: > - Did not use tabs instead of spaces > - Did not put the braces in the correct places > > Fix those, and then move on to the other issues that the > coding style document referrs to. You _will_ have to fix > these issues eventually, so you might as well do them now, as > no one will review your code if you have not done so. > > thanks, > > greg k-h > ------------------------------------------------------- This SF.Net email is sponsored by: NEC IT Guy Games. Get your fingers limbered up and give it your best shot. 4 great events, 4 opportunities to win big! Highest score wins.NEC IT Guy Games. Play to win an NEC 61 plasma display. Visit http://www.necitguy.com/?r _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
