On Saturday 07 May 2005 2:59 pm, Alan Stern wrote:
> On Sat, 7 May 2005, David Brownell wrote:
> > @@ -1267,9 +1267,6 @@
> > struct dummy_ep *ep2;
> >
> > setup = *(struct usb_ctrlrequest*) urb->setup_packet;
> > - le16_to_cpus (&setup.wIndex);
> > - le16_to_cpus (&setup.wValue);
> > - le16_to_cpus (&setup.wLength);
> > if (setup.wLength != urb->transfer_buffer_length) {
> > maybe_set_status (urb, -EOVERFLOW);
> > goto return_urb;
>
> This part of the update is clearly inadequate, since the code goes on to
> use setup.wIndex, setup.wValue, and setup.wLength. In fact setup.wLength
> is used in the very next line after the deleted section!
Whoops, yes -- my bad. I just threw that bit in at the last minute,
knowing it needed to be done ... I forgot that driver hadn't already
been updated to be safe for "sparse -Wbitwise" (outside those lines).
> Greg, if you want to go ahead an apply the patch anyway, I'll send a
> separate patch in a few days to fix this up.
Thanks.
- Dave
-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.
Get your fingers limbered up and give it your best shot. 4 great events, 4
opportunities to win big! Highest score wins.NEC IT Guy Games. Play to
win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
