On Fri, 2005-05-13 at 00:51 +0400, Roman Kagan wrote: > On Thu, May 12, 2005 at 06:56:34PM +0200, Oliver Neukum wrote: > > static inline int usbatm_submit_urb(struct urb *urb) > > > > You'll enter this with irqs off and will leave it with irqs on. > > Mind elaborating a bit? I can see that we may enable irqs with > spin_unlock_irq() on the error path, but how do we enter > usbatm_submit_urb() with irqs off? It's only called from tasklets and > user context. Am I missing anything obvious?
I'm with Roman on this one. Maybe we should add a comment... D. ------------------------------------------------------- This SF.Net email is sponsored by Oracle Space Sweepstakes Want to be the first software developer in space? Enter now for the Oracle Space Sweepstakes! http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
