-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Many thanks for having inspected the code.
I hadn't worried about memory leaks yet.

> +     trust_table[0] = dev;
> 
> 6. Why have a table if only one is allowed?
Only one is allowed because there is no table management yet

> In
> +static void trust_isoc_out_callback (struct urb *urb, struct pt_regs *regs)
> 
> 1. This does a lot of work. Maybe better in a tasklet.
I'll modify the code.

Gabriele
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCj888iUN9h8pkTqERAuIDAJ9Zi8vagwOxsP1E6Y1RqwEtD85VlgCfV82r
37R+AJ3skX42QyjrAzwo5oY=
=Zp31
-----END PGP SIGNATURE-----


-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7412&alloc_id=16344&op=click
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to