On Sat, 21 May 2005 21:07:37 -0700 David Brownell <[EMAIL PROTECTED]> wrote:
> On Saturday 14 May 2005 8:23 am, Botond Botyanszki wrote: > > Hello, > > > > I've ported the old sl811_cs driver to use the new sl811-hcd code in > > 2.6. There are quite a few people with the RATOC REX-CFU1 usb compact > > flash card on PDAs who would benefit from this. > > I have tested the driver on arm (zaurus) and works well. > > OK, as promised: here's an updated version, split into two patches, > which I'd like you to test. I tested the patch and there are some issues. >From a quick glance it seems that the data/addr resources are requested twice, both in sl811_cs via platform_device_register() and then in the probe function of the hcd driver but the release order is different, sl811h_remove is called after cs_release and this causes some trouble: kernel: sl811_cs: sl811_cs_release(0xc3c30160) kernel: Badness in __release_resource at kernel/resource.c:184 kernel: [<c003dbf4>] (release_resource+0x0/0xd8) from [<c012e8f8>] (platform_device_unregister+0x60/0x6c) ... kernel: Trying to free nonexistent resource <c4860001-c4860001> kernel: Trying to free nonexistent resource <c4860000-c4860000> Is the resource requisition necessary in both modules? If it isn't, using device_register() instead of platform_device register() might eliminate the problem. The second issue is some irq problem that the new changes in sl811-hcd.c introduced. When plugging in a usb device, it is recognized only after a few seconds of delay and unplugging goes unnoticed frequently, resulting in various errors. See the attached log snippet. I'll investigate these issues a bit further.
zaurus.log
Description: Binary data
