On Tue, 24 May 2005 13:21:27 +0100, Ian Abbott <[EMAIL PROTECTED]> wrote:
> +++ b/drivers/usb/serial/io_edgeport.c 2005-05-16 06:05:08 -07:00
> @@ -2803,9 +2803,13 @@
> static void unicode_to_ascii (char *string, short *unicode, int
> unicode_size)
> {
> + if (unicode_size <= 0)
> + return;
> string[unicode_size] = 0x00;
> This was backported from 2.6.10 and is apparently to work around a gcc
> -Os bug that generates incorrect code without this patch when the
> 'unicode_size' parameter is negative, leading to an oops. []
Ian, look closer please. Where do you think the NUL is assigned when
unicode_size is negative? The gcc is correct.
> The thing that's puzzling me is why does the workaround not bother
> null-terminating the string?
Bug inside bugfix.
-- Pete
-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
