Hi all, Technically, the readurb status is not nessecary, but I noticed that it has potential to cause a problem later if not initialized. I have not specifically seen a problem, I just set the readurb in good faith to maybe alleviate problems in the future.
What do I need to do here? I'll sign off on the patch included in the bug report, it looks good and works for me. Adam On 6/1/05, Greg KH <[EMAIL PROTECTED]> wrote: > On Wed, Jun 01, 2005 at 03:35:08PM -0700, Nishanth Aravamudan wrote: > > The following patch addresses BugMe #4432. > > > > Description: Initialize status fields in the read and write urbs to > > prevent a race condition with open/read/close - open/write/close > > sequences. > > > > Signed-off-by: Adam Oldham <[EMAIL PROTECTED]> > > Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> > > Sorry, but no, you can not add a Signed-off-by: line for someone else. > Adam will have to add it himself. > > > diff -urpN 2.6.12-rc5/drivers/usb/class/usblp.c > > 2.6.12-rc5-dev/drivers/usb/class/usblp.c > > --- 2.6.12-rc5/drivers/usb/class/usblp.c 2005-06-01 10:30:27.000000000 > > -0700 > > +++ 2.6.12-rc5-dev/drivers/usb/class/usblp.c 2005-06-01 15:30:07.000000000 > > -0700 > > @@ -379,6 +379,8 @@ static int usblp_open(struct inode *inod > > usblp->writeurb->transfer_buffer_length = 0; > > usblp->wcomplete = 1; /* we begin writeable */ > > usblp->rcomplete = 0; > > + usblp->writeurb->status = 0; > > + usblp->readurb->status = 0; > > We don't need to set the readurb status, right Adam? > > thanks, > > greg k-h > -- -Software Engineer, Gilbarco Inc -Located in Greensboro, NC -Website and blog: http://www.bighracing.com/blog ------------------------------------------------------- This SF.Net email is sponsored by Yahoo. Introducing Yahoo! Search Developer Network - Create apps using Yahoo! Search APIs Find out how you can build Yahoo! directly into your own Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005 _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
