Greg, as per David's recommendation, could we get this small patch expedited for 2.6.12 final?

Problem: Failed to recognize Zaurus SL 6000 as usbnet device. Hasn't worked 
since 2.6.10.
Fix: In 2.6.12-rc5 drivers/usb/net/usbnet.c
Check two GUIDs not just one. Submitted-by: Gerald Skerbitz <[EMAIL PROTECTED]>
Signed-off-by: David Brownell <[EMAIL PROTECTED]>

Patch:
--- linux-2.6.12-rc5/drivers/usb/net/usbnet.c.orig      2005-06-01 
18:06:20.000000000 -0500
+++ linux-2.6.12-rc5/drivers/usb/net/usbnet.c   2005-06-01 18:29:30.000000000 
-0500
@@ -2765,7 +2765,7 @@ static int blan_mdlm_bind (struct usbnet
                        }
                        /* expect bcdVersion 1.0, ignore */
                        if (memcmp(&desc->bGUID, blan_guid, 16)
-                                   && memcmp(&desc->bGUID, blan_guid, 16) ) {
+                                   && memcmp(&desc->bGUID, safe_guid, 16) ) {
                                /* hey, this one might _really_ be MDLM! */
                                dev_dbg (&intf->dev, "MDLM guid\n");
                                goto bad_desc;



On Wed, 1 Jun 2005, David Brownell wrote:
On Wednesday 01 June 2005 8:03 pm, [EMAIL PROTECTED] wrote:
I read Documentation/SubmittingPatches and came up with the attached pach file.
It's against the 2.6.12-rc5 tree. Is posting it here sufficient?

You skipped step 11 -- no "Signed-Off-By".  Other than that, and the
lack of a patch description ("check two GUIDs not just one"), it looks
fine to me.  I usually put together a patch with (a) description,
(b) signed-off, (c) diff -u output, all in one file, and send as an
attachment (safe from email mangling) ... to this list, and CC
[EMAIL PROTECTED] too.  Thanks!

In this case, you can also append

Signed-off-by: David Brownell <[EMAIL PROTECTED]>

and it'd be worth asking Greg to expedite this for the 2.6.12 final
patches ... I'm suspecting that's not all that far away now.

- Dave

--
[EMAIL PROTECTED]
gerry
Problem: Failed to recognize Zaurus SL 6000 as usbnet device. Hasn't worked 
since 2.6.10.
Fix: In 2.6.12-rc5 drivers/usb/net/usbnet.c 
         Check two GUIDs not just one. 
Submitted-by: Gerald Skerbitz <[EMAIL PROTECTED]>
Signed-off-by: David Brownell <[EMAIL PROTECTED]>

Patch:
--- linux-2.6.12-rc5/drivers/usb/net/usbnet.c.orig      2005-06-01 
18:06:20.000000000 -0500
+++ linux-2.6.12-rc5/drivers/usb/net/usbnet.c   2005-06-01 18:29:30.000000000 
-0500
@@ -2765,7 +2765,7 @@ static int blan_mdlm_bind (struct usbnet
                        }
                        /* expect bcdVersion 1.0, ignore */
                        if (memcmp(&desc->bGUID, blan_guid, 16)
-                                   && memcmp(&desc->bGUID, blan_guid, 16) ) {
+                                   && memcmp(&desc->bGUID, safe_guid, 16) ) {
                                /* hey, this one might _really_ be MDLM! */
                                dev_dbg (&intf->dev, "MDLM guid\n");
                                goto bad_desc;


Reply via email to