On Sat, 4 Jun 2005 10:50:57 +0300 Kiril Jovchev wrote: | On 6/3/05, Greg KH <[EMAIL PROTECTED]> wrote: | > On Fri, Jun 03, 2005 at 03:37:01PM +0300, Kiril Jovchev wrote: | > | > Please read Documentation/Submitting patches for how to do this | > properly. Your patch was linewrapped, and you didn't have a good | Using Gmail to send was not probably a good idea. | | > changelog entry, and no Signed-off-by: line :( | Sorry about the Signed-off-by: | I haven't found that in the Documentation.
It's in Documentation/SubmittingPatches . | > | > | > Adding changelog comments to the driver itself is not a good idea. | Where I have to put the changelog comments? | The previous comments are in the current driver source. Before we had an SCM for the kernel source, we did put them directly in the source code. How we put metadata (like changelog comments) in the SCM files, not in the source code. so your patch description will be logged in the metadata. Just make sure to use good patch descriptions. --- ~Randy ------------------------------------------------------- This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput a projector? How fast can you ride your desk chair down the office luge track? If you want to score the big prize, get to know the little guy. Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
