Pete Zaitcev wrote: > On Mon, 06 Jun 2005 20:50:28 -0700, Phil Dibowitz <[EMAIL PROTECTED]> wrote: > > >>>>>--- linux-2.4.31/drivers/usb/storage/unusual_devs.h Wed Nov 17 >>>>>12:54:21 2004 >>>>>+++ linux-2.4.31-bzyk/drivers/usb/storage/unusual_devs.h Wed Jun 1 >>>>>21:18:28 2005 >>>>>@@ -255,6 +255,15 @@ UNUSUAL_DEV( 0x054c, 0x0010, 0x0106, 0x >>>>> US_SC_SCSI, US_PR_DEVICE, NULL, >>>>> US_FL_SINGLE_LUN | US_FL_MODE_XLATE ), >>>>> >>>>>+/* Reported by [EMAIL PROTECTED] >>>>>+ * This entry lets Sony DSC-V3 to work >>>>>+ */ >>>>>+UNUSUAL_DEV( 0x054c, 0x0010, 0x0500, 0x0500, >>>>>+ "Sony", >>>>>+ "DSC-V3", >>>>>+ US_SC_8070, US_PR_DEVICE, NULL, >>>>>+ US_FL_SINGLE_LUN | US_FL_MODE_XLATE ), >>>>>+ >>>>>/* Reported by [EMAIL PROTECTED] */ >>>>>UNUSUAL_DEV( 0x054c, 0x0025, 0x0100, 0x0100, >>>>> "Sony", > > >>>>Does 2.4 still accept such "new hardare usability fixes"? > > > Kinda sorta yes. Sorry, I missed the original message. > > >>Pete - you want to take this then? > > > Phil, if you stand behind it, sure. But I stopped diff-ing against > your master copy of unusual_devs.h in 2.6 and it's on case-by-case > basis at present.
OK. Well I'll say this - an almost identical patch is in 2.6 and has been for a while - minus the XLATE flag which is 2.4 specific. I have no idea what the XLATE flag does though, so I have no idea if it is needed. Other than that, the overall format of the patch is currect and I like it. I will note of course that I never touched any kernel code before 2.6, so keep that in mind. That's my level of standing behind it. ;) (As a side note, once I removed all the 2.4 specific stuff, I'm sure it became impossible for you to diff against my copy - hence I suspected you wouldn't accept such a patch - but if you're willing to do one-offs, I'll do a general inspection for sanity). -- Phil Dibowitz [EMAIL PROTECTED] Freeware and Technical Pages Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "They that can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety." - Benjamin Franklin, 1759
signature.asc
Description: OpenPGP digital signature
