On Mon, 11 Jul 2005 17:52:31 +0530 (IST), Chinmay Kale <[EMAIL PROTECTED]>
wrote:
> port->serial->type->close(port, filp);
> - port->tty = NULL;
> + /* Open on the port can be pending while a close
> + * is in progress.
> + * Nullify tty only if there are no open ports */
> + if (port->open_count == 0) {
> + port->tty = NULL;
This is a very bad idea, in my opinion. If opens and closes overlap,
it remains hideously racy even if you try to plug it this way.
This "fix" fixes nothing.
We need a static semaphore to divorce open and close.
-- Pete
-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP,
AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
