On Thu, 14 Jul 2005 10:22:59 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> wrote:
> However this ignores the matter of retrying submissions that fail with > -ENXIO, -EAGAIN, or -ENOMEM. Maybe you could add an additional argument > to usb_sg_submit to specify whether such failures should be retried. I don't like such functions with variable behaviour and the duplication is not big enough here. As for usb_sg_cancel in case of an error, the logic was that it makes no difference, so why do it? Even if I call it, I cannot return with anything but zero error code (unless the very first submit fails). But calling this cancel adds an opportunity for racing somewhere. I do not trust our code in this area. Remember, ub must not crash. Unlinking is the crashiest thing in the whole stack, so heck no. -- Pete ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
