Pete: Are you still accepting bugfixes for 2.4? The patch below (as547) corrects two minor errors, one in the file_storage gadget driver (need to send a length-zero packet if a control response is short) and one in the alternate UHCI driver (need to set the QH bit in the frame list). Both of these are back-ports of things that have been in 2.6 for several releases.
Alan Stern Signed-off-by: Alan Stern <[EMAIL PROTECTED]> --- 2.4.30-orig/drivers/usb/gadget/file_storage.c 2004-08-07 19:26:05.000000000 -0400 +++ 2.4.30/drivers/usb/gadget/file_storage.c 2005-07-26 10:35:02.000000000 -0400 @@ -1454,6 +1454,7 @@ /* Respond with data/status or defer until later? */ if (rc >= 0 && rc != DELAYED_STATUS) { fsg->ep0req->length = rc; + fsg->ep0req->zero = (rc < ctrl->wLength); fsg->ep0req_name = (ctrl->bRequestType & USB_DIR_IN ? "ep0-in" : "ep0-out"); rc = ep0_queue(fsg); --- 2.4.30-orig/drivers/usb/host/uhci.c 2003-06-13 10:51:36.000000000 -0400 +++ 2.4.30/drivers/usb/host/uhci.c 2005-07-26 10:39:02.000000000 -0400 @@ -2924,7 +2924,7 @@ } /* Only place we don't use the frame list routines */ - uhci->fl->frame[i] = uhci->skeltd[irq]->dma_handle; + uhci->fl->frame[i] = uhci->skeltd[irq]->dma_handle | UHCI_PTR_QH; } start_hc(uhci); ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel