On Thu, 4 Aug 2005, Olav Kongas wrote: > Greg, > > This patch changes the isp116x-hcd to use interrupt instead > of root hub polling. > > Please apply, if Alan won't complain. > Olav
There's one little problem with this snatch of code: > + /* Report no status change now, if we are scheduled to be > + called later */ > + if (time_before(jiffies, hcd->rh_timer.expires)) > + return 0; You shouldn't be checking against the expiration time; you should call timer_pending() instead. After all, the expiration time is meaningless if the timer isn't active. Alan Stern ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
