On Fri, 5 Aug 2005 18:02:36 +0400
Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
> > + ep->regs [0] = MQ_UDC_CLEAR_FIFO;
> > + ep->regs [0] = 0;
> ^^^^^^^^^^^
> > + if (ep->num == 0) {
> > + ep->regs [2] = MQ_UDC_CLEAR_FIFO;
> > + ep->regs [2] = 0;
> ^^^^^^^^^^^
> Two times in a row. What do you really want to do here?
This is a I/O register, it isn't supposed to work like a normal memory
location :) If I won't clear the "CLEAR_FIFO" bit, the FIFO will stay
clear forever. If I won't set it, FIFO won't clear.
> > +static void *mq_alloc_buffer (struct usb_ep *_ep, unsigned bytes,
> > + dma_addr_t *dma, int gfp_flags)
> > +{
> > + return kmalloc (bytes, gfp_flags);
> > +}
> > +
> > +static void mq_free_buffer (struct usb_ep *_ep, void *buf,
> > dma_addr_t dma,
> > + unsigned bytes)
> > +{
> > + kfree (buf);
> > +}
> Please, drop this useless bloated wrappers.
These are part of standard gadget interface. On some platforms they are
more than kmalloc/kfree; for MQ11xx they just happened to be so simple.
All other your notes were helpful, thanks.
--
Greetings,
Andrew
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
