On Wed, Jul 13, 2005 at 02:02:11AM +0400, Alexey Dobriyan wrote:
> On Tuesday 12 July 2005 22:56, Greg KH wrote:
> >  drivers/usb/input/keyspan_remote.c     |  633 ++++++++++++++++++++++++++
> 
> Greg, Michael, sparse asks whether cpu_to_le16() are missed.
> 
> $ cat -n drivers/usb/input/keyspan_remote.c | head -n 437 | tail -n 4
>    434          /* See if the offered device matches what we can accept */
>    435          if ((udev->descriptor.idVendor != USB_KEYSPAN_VENDOR_ID) ||
>    436              (udev->descriptor.idProduct != USB_KEYSPAN_PRODUCT_UIA11) 
> )
>    437                  return -ENODEV;
> 

Thanks, I've now fixed this in my tree (that whole check doesn't need to
be there...)

greg k-h


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to