Greg: huge thanks for the detailed critique!
Jimmy: let me know if you need/want any help with review
and/or patch construction and shipping. :-)
Bart
In message <[EMAIL PROTECTED]> you wrote:
> On Wed, Aug 10, 2005 at 04:50:35PM -0700, [EMAIL PROTECTED] wrote:
> > +typedef struct ax88178 ax88178_t;
>
> No typedefs in kernel code please. Don't create new ones.
>
> > +
> > +static unsigned long multicast_filter_limit = 32;
> > +
> > +static void fill_skb_pool(ax88178_t *);
> > +static void free_skb_pool(ax88178_t *);
> > +static int ax88178_link_up( void* arg );
> > +static int async_set_registers(ax88178_t * dev, u8 index, u16 regdata1,
> > u16 regdata2, u16 size);
>
> Your patch is linewrapped, and can't be applied :(
>
> Care to try it again?
>
> > + while(!test_bit(AX88178_UNPLUG, &dev->flags) )
> > + {
>
> Please use the proper formatting for your braces. Same thing for your
> if statements.
>
> Also, put a space after the while and no spaces within the (). So that
> should be:
> while(!test_bit(AX88178_UNPLUG, &dev->flags)) {
>
>
> > + wait_event_interruptible( dev->speed_queue, dev->state &
> > STATE_SPEED_CHANGE );
>
> Again, no spaces.
>
> > +#if DEBUG
>
> No #ifdefs in .c files. Please use dev_dbg() instead.
>
> thanks,
>
> greg k-h
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
