David Hollis wrote:

I wonder if it might just be simpler to wrap the 'val' in cpu_to_le16 in the ax8817x_mdio_read/write functions. Would make the rest of the code

cleaner and easier to follow.

Pointers to these functions are set in the dev->mii structure, and must follow the ethtool_mii API. That means the caller must do the endian conversion. Otherwise you'll break ethtool support. I suppose you could put a endian conversion wrapper on top for the calls local to usbnet.c/asix.c.

--Jamie




-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to